-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use Vitest public API instead of Vitest CLI #253
feat: use Vitest public API instead of Vitest CLI #253
Conversation
Very exciting stuff! Looking forward to this! |
6524cda
to
67faa54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that this is a draft PR, but thought it could be helpful already now with a preliminary review on a take-it-or-leave-it basis ❤️
Great work, and I can't wait to see this merged. I think it will help stabilize a lot ❤️
Yeah, should be possible. I made it so it runs tests correctly now, but it doesn't report the result because the test run uses a different request. I need to think more about the architecture there (already have some ideas). This PR should be merged this week after we release locations in Vitest, and I will publish it with a beta tag, so everyone can join in. |
Awesome! 😍 Can't wait! Thanks for the status update. Can you elaborate on what you mean by the request being different? Maybe me/others could then chime in with architecture proposals and/or ideas. |
Awesome! How can I try this? ❤️ |
Yes, I know. I am rewriting our release script. Please be patient and just wait. |
Hi @sheremet-va, just posting this here rather than making an issue as I didn't know if you wanted bug reports from the pre-release yet (having only just landed it!). I was curious to try it out with https://github.com/chriswheeldon-peakon/vitest-workspace-cwd but the extension fails to load with:
This is a monorepo with multiple vite.config.ts files (one in each package). |
Please, create a separate issue with a reproduction. This PR is not a place to follow all bugs with the current implementation. We specifically released it as a pre-released to find all edge cases (like yours). |
This PR switches to use public Vitest API instead of calling
vitest
CLI directly. Improvements that come with it:Known issues
vite.config
orvitest.config
file to function