Use system gcloud by default #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is faster by about 20 seconds per job. this is a breaking change for any job that installs custom gcloud components, which at the moment does not appear to include any repos. this will also mean that the latest gcloud is not always installed if the default github actions runner does not have the latest version
|
according to https://vivante-team.slack.com/archives/C022KDV0W6P/p1726687226445679, this might break when ubuntu: latest starts referring to 24.04 |
alkallio
approved these changes
Oct 31, 2024
figadore
added a commit
that referenced
this pull request
Oct 31, 2024
reverts the default added in #12 this PR should be merged if/when `ubuntu/latest` starts referring to ubuntu 24.04 which ships without a `gcloud` binary built in. this will add ~20 seconds to each job that needs gcloud, so it may also be worth investigating making a custom image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is faster by about 20 seconds per job (which is ~1 minute for most jobs that push a docker image). this would be a breaking change for any job that installs custom gcloud components, which at the moment does not appear to include any repos. this will also mean that the latest gcloud is not always installed if the default github actions runner does not have the latest version. there is a new parameter that allows this behavior to be overridden