Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to use hex string as secret key #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

ZTHawk
Copy link

@ZTHawk ZTHawk commented Oct 17, 2021

I have added an option (checkbox + msg.isSecretKeyHex (bool)) to interpret the secret key as a hex string.
This allows to use byte arrays to be used as a key (byte array as hex string).

This also contains the pull request by @kongkrit.

@ZTHawk
Copy link
Author

ZTHawk commented May 18, 2024

This is an old request, but I am using those changes frequently.
Will you ever merge the pull request?

@vivekrp
Copy link
Owner

vivekrp commented Jun 28, 2024

Hey @ZTHawk, sorry for the delayed response. I hadn't reviewed this PR earlier. I initially created this package for personal use when I was working with NodeRED a while ago. The original package lacked a feature I needed, so I forked it and added that functionality when the original creator was inactive. Recently, I noticed on the npmjs website that thousands of users are downloading this package, so I came to check and saw this PR. I didn't realize so many people were using it. Will the changes you're proposing break any existing functionality of this package? I haven't worked on NodeRED for almost 2 years now, so I'm unsure of the recent changes.

@ZTHawk
Copy link
Author

ZTHawk commented Jun 29, 2024

Hi, There is a breaking change from the merge 94b51bc ("secrectkey" to "secretkey").
This should affect users that are passing the secret key with msg. I am not sure what happens if key is written in the UI and then the module is updated.

Other than that, it is behaving the same way.
You can also decide to implement it your way. All I need is the feature to have the key to be interpreted as a hex (binary) key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants