Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the top position of the rich text editor toolbar #2533

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

jamesricky
Copy link
Contributor

When used inside AdminComponentRoot but not as a direct child, the top position should not take the height of the breadcrumbs into account, as this will move the toolbar too far down.


PR Checklist

  • Verify if the change requires a changeset. See CONTRIBUTING.md
  • Link to the respective task if one exists: COM-1075
  • Provide screenshots/screencasts if the change contains visual changes
Previously Now
RichText Previously RichText Now

When used inside `AdminComponentRoot` but not as a direct child, the
top position should not take the height of the breadcrumbs into
account, as this will move the toolbar too far down.
Initially, during the themeing/styling refactor it was planned to
remove all those class names, but this is no longer the case so we can
keep them.
@jamesricky jamesricky self-assigned this Sep 16, 2024
@johnnyomair johnnyomair changed the title Fix the top position of the rich-text toolbar Fix the top position of the rich text editor toolbar Sep 16, 2024
@johnnyomair johnnyomair merged commit 46f9322 into main Sep 17, 2024
11 checks passed
@johnnyomair johnnyomair deleted the fix-top-position-for-nested-rte branch September 17, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants