[extension-selenium] Add set variable steps #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1030 +/- ##
=========================================
Coverage 95.10% 95.11%
- Complexity 4594 4598 +4
=========================================
Files 603 605 +2
Lines 12467 12488 +21
Branches 909 909
=========================================
+ Hits 11857 11878 +21
Misses 475 475
Partials 135 135
Continue to review full report at Codecov.
|
uarlouski
force-pushed
the
addSaveValueSteps
branch
3 times, most recently
from
bc11d85
to
0d82c28
Compare
uarlouski
changed the title
uarlouski
requested review from
valfirst,
abudevich,
ikalinin1 and
TatianaTochko
uarlouski
force-pushed
the
addSaveValueSteps
branch
from
0d82c28
to
37e15ff
Compare
valfirst
requested changes
Oct 15, 2020
vividus-extension-selenium/src/main/java/org/vividus/bdd/steps/ui/GenericSetVariableSteps.java
Outdated
Show resolved
Hide resolved
vividus-extension-selenium/src/main/java/org/vividus/ui/action/IElementActions.java
Outdated
Show resolved
Hide resolved
ikalinin1
reviewed
Oct 15, 2020
vividus-tests/src/main/resources/story/integration/SetVariableSteps.story
Show resolved
Hide resolved
uarlouski
force-pushed
the
addSaveValueSteps
branch
6 times, most recently
from
e7e3d5d
to
8eeeb79
Compare
uarlouski
force-pushed
the
addSaveValueSteps
branch
from
8eeeb79
to
35e32c0
Compare
valfirst
requested changes
Oct 16, 2020
vividus-plugin-mobile-app/src/main/java/org/vividus/mobileapp/action/TouchActions.java
Outdated
Show resolved
Hide resolved
vividus-extension-selenium/src/main/java/org/vividus/bdd/steps/ui/GenericSetVariableSteps.java
Outdated
Show resolved
Hide resolved
- When I save text of context element to $scopes variable `$variableName` - When I save `$attributeName` attribute value of context element to $scopes variable `$variableName` - When I save `$attributeName` attribute value of element located `$locator` to $scopes variable `$variableName`
uarlouski
force-pushed
the
addSaveValueSteps
branch
from
35e32c0
to
9684ab1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ikalinin1
approved these changes
Oct 16, 2020
valfirst
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs be fixed for 0.3.0 #1032