[plugin-datetime] Support timezone in 'toEpochSecond' expression #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
requested review from
ikalinin1,
uarlouski,
abudevich and
TatianaTochko
Codecov Report
@@ Coverage Diff @@
## master #1219 +/- ##
============================================
- Coverage 95.45% 95.45% -0.01%
+ Complexity 4870 4868 -2
============================================
Files 649 649
Lines 13297 13296 -1
Branches 961 961
============================================
- Hits 12693 12692 -1
Misses 474 474
Partials 130 130
Continue to review full report at Codecov.
|
uarlouski
reviewed
Dec 11, 2020
| @@ -32,7 +32,7 @@ public EpochExpressionProcessors(DateUtils dateUtils) | |||
| { | |||
| super(List.of( | |||
| new UnaryExpressionProcessor("toEpochSecond", | |||
| arg -> String.valueOf(dateUtils.toEpochSecond(arg, DateTimeFormatter.ISO_DATE_TIME))), | |||
| arg -> String.valueOf(dateUtils.parseDateTime(arg, DateTimeFormatter.ISO_DATE_TIME).toEpochSecond())), | |||
| new UnaryExpressionProcessor("fromEpochSecond", | |||
| arg -> DateTimeFormatter.ISO_DATE_TIME.format(dateUtils.fromEpochSecond(parseLong(arg)))) | |||
| )); | |||
There was a problem hiding this comment.
don't you mind to add docs for these expressions?
There was a problem hiding this comment.
that will be added in another PR
uarlouski
approved these changes
Dec 11, 2020
valfirst
force-pushed
the
support-timezone-in-to-epoch-second-expression
branch
from
b254825
to
abedbc4
Compare
valfirst
force-pushed
the
support-timezone-in-to-epoch-second-expression
branch
from
abedbc4
to
cd354ee
Compare
|
Kudos, SonarCloud Quality Gate passed! |
uarlouski
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.