Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vividus] Add generic while-like step with iteration delays #1268

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

valfirst
Copy link
Collaborator

Closes #1235

@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #1268 (428713d) into master (b89105d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1268   +/-   ##
=========================================
  Coverage     95.49%   95.49%           
- Complexity     4908     4913    +5     
=========================================
  Files           654      655    +1     
  Lines         13415    13429   +14     
  Branches        962      963    +1     
=========================================
+ Hits          12810    12824   +14     
  Misses          478      478           
  Partials        127      127           
Impacted Files Coverage Δ Complexity Δ
...ava/org/vividus/util/wait/MaxTimesBasedWaiter.java 100.00% <100.00%> (ø) 5.00 <5.00> (?)
...in/java/org/vividus/bdd/steps/ExecutableSteps.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2fb603...428713d. Read the comment docs.

@valfirst valfirst force-pushed the add-generic-while-like-step-with-iteration-delays branch from 58d5141 to 296dcf1 Compare December 23, 2020 11:36
@@ -80,3 +80,10 @@ When I execute steps at most 5 times while variable `var` is < `10`:
|step |
|When I initialize the scenario variable `var` with value `#{eval(${var} + 1)}`|
Then `${var}` is = `10`

Scenario: Verify step: When I execute steps at most $max times while variable `$variableName` is $comparisonRule `$expectedValue`:$stepsToExeute
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scenario title differs from the step under test

@valfirst valfirst force-pushed the add-generic-while-like-step-with-iteration-delays branch from 296dcf1 to c2fe40a Compare December 23, 2020 12:43
@@ -79,3 +79,18 @@ Then JSON element from `${song}` by JSON path `$` is equal to `
"SongTitle": "Real Sugar"
}
]` ignoring array order

Scenario: Wait for the data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is ticker id missing?

@valfirst valfirst force-pushed the add-generic-while-like-step-with-iteration-delays branch from c2fe40a to 428713d Compare December 23, 2020 13:18
@sonarcloud
Copy link

sonarcloud bot commented Dec 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@valfirst valfirst merged commit 7e6a220 into master Dec 23, 2020
@valfirst valfirst deleted the add-generic-while-like-step-with-iteration-delays branch December 23, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamoDB plugin updating
3 participants