Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin-aws-s3] Add ability to collect S3 objects keys #1350

Merged
merged 1 commit into from
Jan 16, 2021

Conversation

valfirst
Copy link
Collaborator

Closes #1313
Closes #1315

@codecov
Copy link

codecov bot commented Jan 16, 2021

Codecov Report

Merging #1350 (caa0122) into master (0e00c3b) will increase coverage by 6.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1350      +/-   ##
============================================
+ Coverage     88.98%   95.29%   +6.30%     
+ Complexity     4934     4787     -147     
============================================
  Files           665      665              
  Lines         13450    13497      +47     
  Branches        961      962       +1     
============================================
+ Hits          11969    12862     +893     
+ Misses         1347      505     -842     
+ Partials        134      130       -4     
Impacted Files Coverage Δ Complexity Δ
...util/src/main/java/org/vividus/util/DateUtils.java 87.50% <ø> (ø) 3.00 <0.00> (?)
...n/java/org/vividus/aws/s3/steps/S3BucketSteps.java 100.00% <100.00%> (ø) 20.00 <10.00> (+10.00)
...dus/configuration/DeprecatedPropertiesHandler.java 96.87% <0.00%> (+6.25%) 0.00% <0.00%> (-11.00%) ⬆️
...in/java/org/vividus/configuration/BeanFactory.java 93.93% <0.00%> (+15.15%) 0.00% <0.00%> (-13.00%) ⬆️
...in/java/org/vividus/bdd/log/AllureLogAppender.java 100.00% <0.00%> (+20.00%) 0.00% <0.00%> (-6.00%) ⬆️
...rc/main/java/org/vividus/runner/GenericRunner.java 23.80% <0.00%> (+23.80%) 0.00% <0.00%> (ø%)
...ovy/VariableContextAwareGroovyScriptEvaluator.java 100.00% <0.00%> (+25.00%) 0.00% <0.00%> (-1.00%) ⬆️
.../java/org/vividus/spring/StartContextListener.java 100.00% <0.00%> (+27.27%) 0.00% <0.00%> (-4.00%) ⬆️
...dus/bdd/expression/GroovyEpxpressionProcessor.java 100.00% <0.00%> (+33.33%) 0.00% <0.00%> (ø%)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e00c3b...caa0122. Read the comment docs.

@valfirst valfirst force-pushed the add-ability-to-collect-s3-object-keys branch from 7304404 to caa0122 Compare January 16, 2021 12:09
@sonarcloud
Copy link

sonarcloud bot commented Jan 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.9% 96.9% Coverage
0.0% 0.0% Duplication

@valfirst valfirst merged commit 9d27995 into master Jan 16, 2021
@valfirst valfirst deleted the add-ability-to-collect-s3-object-keys branch January 16, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extending "AWS S3 Plugin" functionality 2. Extending "AWS S3 Plugin" functionality.
2 participants