Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1369 #1413

Merged
merged 2 commits into from
Feb 14, 2021
Merged

1369 #1413

merged 2 commits into from
Feb 14, 2021

Conversation

ikalinin1
Copy link
Member

@ikalinin1 ikalinin1 commented Feb 8, 2021

Closes #1369
Supersedes #1381

@ghost
Copy link

ghost commented Feb 8, 2021

DeepCode's analysis on #804fd2 found:

  • ℹ️ 1 minor issue. 👇

Top issues

Description Example fixes
Use java.util.ArrayList instead of java.util.LinkedList. Using java.util.LinkedList can lead to unnecessary performance overhead if the list is randomly accessed. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #1413 (804fd23) into master (0b5d2db) will increase coverage by 0.00%.
The diff coverage is 94.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master    #1413    +/-   ##
==========================================
  Coverage     95.36%   95.36%            
  Complexity     4837     4837            
==========================================
  Files           676      682     +6     
  Lines         13623    13875   +252     
  Branches        962      979    +17     
==========================================
+ Hits          12991    13232   +241     
- Misses          504      513     +9     
- Partials        128      130     +2     
Impacted Files Coverage Δ Complexity Δ
.../org/vividus/analytics/AnalyticsStoryReporter.java 100.00% <ø> (ø) 12.00 <0.00> (-3.00)
...g/vividus/bdd/SystemStoriesAwareStoryReporter.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...n/java/org/vividus/bdd/BatchedPerformableTree.java 81.81% <50.00%> (ø) 9.00 <1.00> (ø)
...src/main/java/org/vividus/bdd/BatchedEmbedder.java 91.54% <66.66%> (ø) 15.00 <0.00> (ø)
vividus/src/main/java/org/vividus/bdd/Status.java 96.77% <94.11%> (+3.91%) 0.00 <0.00> (ø)
...dus/configuration/DeprecatedPropertiesHandler.java 97.72% <96.92%> (+0.85%) 0.00 <0.00> (ø)
.../java/org/vividus/bdd/StatisticsStoryReporter.java 99.09% <99.09%> (ø) 0.00 <0.00> (?)
...vividus/bdd/report/allure/AllureStoryReporter.java 96.64% <100.00%> (ø) 112.00 <2.00> (ø)
...llure/listener/AllureAssertionFailureListener.java 100.00% <100.00%> (ø) 2.00 <1.00> (-2.00)
...ividus/bdd/report/allure/model/StatusPriority.java 85.18% <100.00%> (+1.85%) 13.00 <5.00> (+5.00)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b5d2db...804fd23. Read the comment docs.

@uarlouski uarlouski self-requested a review February 12, 2021 11:10
@sonarcloud
Copy link

sonarcloud bot commented Feb 12, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

95.0% 95.0% Coverage
0.0% 0.0% Duplication

@valfirst valfirst merged commit 9452c30 into master Feb 14, 2021
@valfirst valfirst deleted the 1369 branch February 14, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align naming of fail-fast properties
3 participants