Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin-websocket] Add plugin to work with web sockets #1434

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Conversation

uarlouski
Copy link
Member

@uarlouski uarlouski commented Feb 18, 2021

Closes #1402

@ghost
Copy link

ghost commented Feb 18, 2021

Congratulations 🎉. DeepCode analyzed your code in 6.188 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #1434 (0563a39) into master (2183a7c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1434      +/-   ##
============================================
+ Coverage     95.38%   95.41%   +0.02%     
- Complexity     4851     4871      +20     
============================================
  Files           683      684       +1     
  Lines         13903    13972      +69     
  Branches        975      978       +3     
============================================
+ Hits          13262    13331      +69     
  Misses          509      509              
  Partials        132      132              
Impacted Files Coverage Δ Complexity Δ
...rg/vividus/bdd/steps/websocket/WebSocketSteps.java 100.00% <100.00%> (ø) 20.00 <20.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2183a7c...0563a39. Read the comment docs.

@uarlouski uarlouski changed the title [plugin-websocket][draft] Just simple example for further work [plugin-websocket] Add plugin to work with web sockets Feb 26, 2021
@uarlouski uarlouski marked this pull request as ready for review February 26, 2021 11:04
implementation project(':vividus-util')

implementation(group: 'org.springframework', name: 'spring-websocket', version: versions.spring)
implementation(group: 'org.eclipse.jetty.websocket', name: 'websocket-client', version: '9.4.36.v20210114')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9.4.38.v20210224 ? :)

@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2021

@valfirst valfirst merged commit c713a55 into master Mar 1, 2021
@valfirst valfirst deleted the ws branch March 1, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement web sockets support
3 participants