Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[analytics] Use non-encrypted tracking ID #1447

Merged

Conversation

valfirst
Copy link
Collaborator

The default properties encrypted with the default password can't be decrypted when the custom encryption password is used, in other words it completely blocks usage of the custom password

The default properties encrypted with the default password can't be decrypted when the custom encryption password is used, in other words it completely blocks usage of the custom password
@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #1447 (52d3056) into master (f462d4b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1447   +/-   ##
=========================================
  Coverage     95.38%   95.38%           
  Complexity     4848     4848           
=========================================
  Files           683      683           
  Lines         13898    13898           
  Branches        975      975           
=========================================
  Hits          13256    13256           
  Misses          509      509           
  Partials        133      133           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f462d4b...52d3056. Read the comment docs.

@valfirst valfirst merged commit 4d46b17 into master Feb 22, 2021
@valfirst valfirst deleted the analytics-fix-decryption-issues-with-custom-password branch February 22, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants