[plugin-json] Add patch json file step #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EDbarvinsky
commented
Mar 18, 2021
vividus-plugin-json/build.gradle
Outdated
Comment on lines
6
to
10
| implementation project(':vividus-util') | ||
| implementation(group: 'com.jayway.jsonpath', name: 'json-path-assert', version: '2.4.0') { | ||
| exclude module: 'hamcrest-library' | ||
| } | ||
| implementation (group: 'net.javacrumbs.json-unit', name: 'json-unit', version: '2.18.0') |
There was a problem hiding this comment.
Have tried to get rid of this dependencies, but do not succeed. Will discuss tomorrow
valfirst
requested changes
Mar 19, 2021
| import org.vividus.bdd.context.IBddVariableContext; | ||
| import org.vividus.bdd.variable.VariableScope; | ||
|
|
||
| public class JsonSteps |
| } | ||
|
|
||
| @When("I patch content from json '$sourceJsonFilePath' with '$patchJsonFilePath' and put patched json to '$scopes'" | ||
| + " variable with name '$pathVariable'") |
There was a problem hiding this comment.
When I patch JSON `$sourceJson` using `$jsonPatch` and save result to $scopes variable `$variableName`
Codecov Report
@@ Coverage Diff @@
## master #1499 +/- ##
=========================================
Coverage 95.55% 95.56%
- Complexity 4874 4877 +3
=========================================
Files 685 687 +2
Lines 14083 14102 +19
Branches 983 983
=========================================
+ Hits 13457 13476 +19
Misses 493 493
Partials 133 133
Continue to review full report at Codecov.
|
EDbarvinsky
changed the title
valfirst
requested changes
Mar 19, 2021
vividus-plugin-json/src/main/java/org/vividus/bdd/steps/json/JsonPatchSteps.java
Outdated
Show resolved
Hide resolved
vividus-plugin-json/src/main/java/org/vividus/bdd/steps/json/JsonPatchSteps.java
Show resolved
Hide resolved
ikalinin1
reviewed
Mar 22, 2021
ikalinin1
approved these changes
Mar 23, 2021
valfirst
requested changes
Mar 23, 2021
| @@ -0,0 +1,25 @@ | |||
| = Json Plugin | |||
There was a problem hiding this comment.
let's use JSON notation everywhere
| When I patch JSON `$sourceJson` using `$jsonPatch` and save result to $scopes variable `$variableName` | ||
| ---- | ||
|
|
||
| * `$sourceJson` - JSON file to be patched. |
There was a problem hiding this comment.
it's not file, but JSON data
| ---- | ||
|
|
||
| * `$sourceJson` - JSON file to be patched. | ||
| * `$jsonPatch` - JSON file with required patch actions according to https://tools.ietf.org/html/rfc6902#page-6[RFC-6902] |
There was a problem hiding this comment.
not file, similar to the above comment
|
|
||
| * `$sourceJson` - JSON file to be patched. | ||
| * `$jsonPatch` - JSON file with required patch actions according to https://tools.ietf.org/html/rfc6902#page-6[RFC-6902] | ||
| * `$scopes` - xref:parameters:variable-scope.adoc[the comma-separated set of the variables scopes] |
| /** | ||
| * Performs patching of a json and save it to the variable | ||
| * @param sourceJson json file to be patched | ||
| * @param jsonPatch json file with patch actions |
There was a problem hiding this comment.
please see related comments for the documentation
| * `$sourceJson` - JSON file to be patched. | ||
| * `$jsonPatch` - JSON file with required patch actions according to https://tools.ietf.org/html/rfc6902#page-6[RFC-6902] | ||
| * `$scopes` - xref:parameters:variable-scope.adoc[the comma-separated set of the variables scopes] | ||
| * `$variableName` - The variable |
There was a problem hiding this comment.
please add example of using step
| * `$sourceJson` - JSON file to be patched. | ||
| * `$jsonPatch` - JSON file with required patch actions according to https://tools.ietf.org/html/rfc6902#page-6[RFC-6902] | ||
| * `$scopes` - xref:parameters:variable-scope.adoc[the comma-separated set of the variables scopes] | ||
| * `$variableName` - The variable |
valfirst
requested changes
Mar 23, 2021
valfirst
reviewed
Mar 23, 2021
valfirst
reviewed
Mar 23, 2021
valfirst
approved these changes
Mar 23, 2021
uarlouski
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1476