[plugin-mobile-app] Add step to press sequence of keys #1526
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1526 +/- ##
============================================
+ Coverage 95.60% 95.63% +0.02%
- Complexity 4940 4981 +41
============================================
Files 697 702 +5
Lines 14251 14348 +97
Branches 992 995 +3
============================================
+ Hits 13625 13722 +97
Misses 493 493
Partials 133 133
Continue to review full report at Codecov.
|
vividus-plugin-mobile-app/src/main/java/org/vividus/bdd/mobileapp/steps/DeviceSteps.java
Show resolved
Hide resolved
vividus-plugin-mobile-app/src/main/java/org/vividus/bdd/mobileapp/steps/DeviceSteps.java
Outdated
Show resolved
Hide resolved
| .collect(Collectors.collectingAndThen(Collectors.toList(), keyEvents -> | ||
| { | ||
| PressesKey pressesKey = webDriverProvider.getUnwrapped(PressesKey.class); | ||
| keyEvents.forEach(pressesKey::pressKey); |
There was a problem hiding this comment.
it could be a part of the wrapping stream
There was a problem hiding this comment.
it needs to eliminate multiple invocations of webDriverProvider.getUnwrapped(PressesKey.class)
There was a problem hiding this comment.
just unwrap it once before stream start
There was a problem hiding this comment.
what if one of the keys is invalid? then the wrapping becomes pointless
There was a problem hiding this comment.
tricky question: what is better to create a list or to cast an object to another type
|
Kudos, SonarCloud Quality Gate passed! |
No description provided.