Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visual #1608

Merged
merged 2 commits into from
May 4, 2021
Merged

Fix visual #1608

merged 2 commits into from
May 4, 2021

Conversation

ikalinin1
Copy link
Member

fixes #1594

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #1608 (a5ca01b) into master (690679d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1608   +/-   ##
=========================================
  Coverage     95.76%   95.76%           
- Complexity     5091     5094    +3     
=========================================
  Files           712      712           
  Lines         14619    14622    +3     
  Branches       1000      999    -1     
=========================================
+ Hits          14000    14003    +3     
  Misses          485      485           
  Partials        134      134           
Impacted Files Coverage Δ Complexity Δ
...va/org/vividus/visual/bdd/AbstractVisualSteps.java 100.00% <100.00%> (ø) 4.00 <0.00> (ø)
.../org/vividus/accessibility/AccessibilitySteps.java 100.00% <100.00%> (ø) 11.00 <0.00> (ø)
...va/org/vividus/visual/eyes/VisualTestingSteps.java 87.50% <100.00%> (+0.83%) 6.00 <2.00> (+1.00)
.../src/main/java/org/vividus/visual/VisualSteps.java 97.87% <100.00%> (+0.04%) 17.00 <5.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 690679d...a5ca01b. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@valfirst valfirst merged commit 3f126db into master May 4, 2021
@valfirst valfirst deleted the fix_visual branch May 4, 2021 16:19
@ikalinin1 ikalinin1 restored the fix_visual branch September 28, 2021 14:15
@ikalinin1 ikalinin1 deleted the fix_visual branch September 28, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No evidence is generated in a case when execution is aborted due to failure of a visual check step
3 participants