Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin-db] Add ability to check one data set contains another data set #1705

Merged

Conversation

valfirst
Copy link
Collaborator

@valfirst valfirst commented Jun 11, 2021

Closes #1658

@ghost
Copy link

ghost commented Jun 11, 2021

DeepCode's analysis on #748fc0 found:

  • ℹ️ 1 minor issue. 👇

Top issues

Description Example fixes
Consider checking the presence of the optionals value with isPresent before accessing it with get Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !

If you are using our plugins, you might be interested in their successors: Snyk's JetBrains plugin and Snyk's VS Code plugin.

@sonarcloud
Copy link

sonarcloud bot commented Jun 11, 2021

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #1705 (748fc00) into master (dbccfd7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1705   +/-   ##
=========================================
  Coverage     95.83%   95.83%           
- Complexity     5090     5114   +24     
=========================================
  Files           716      719    +3     
  Lines         14693    14699    +6     
  Branches       1003     1004    +1     
=========================================
+ Hits          14081    14087    +6     
  Misses          476      476           
  Partials        136      136           
Impacted Files Coverage Δ
...rg/vividus/bdd/steps/db/DataSetComparisonRule.java 100.00% <100.00%> (ø)
...org/vividus/bdd/steps/db/DataSourceStatistics.java 100.00% <100.00%> (ø)
...n/java/org/vividus/bdd/steps/db/DatabaseSteps.java 99.24% <100.00%> (-0.20%) ⬇️
...rg/vividus/bdd/steps/db/DuplicateKeysStrategy.java 100.00% <100.00%> (ø)
.../java/org/vividus/bdd/steps/db/QueryStatistic.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbccfd7...748fc00. Read the comment docs.

@valfirst valfirst merged commit 1eebd52 into master Jun 11, 2021
@valfirst valfirst deleted the add-ability-to-check-one-data-set-contains-another-data-set branch June 11, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants