Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crossbrowsertesting] Add integration for CrossBrowserTesting #1755

Merged
merged 1 commit into from
Jun 29, 2021
Merged

[crossbrowsertesting] Add integration for CrossBrowserTesting #1755

merged 1 commit into from
Jun 29, 2021

Conversation

uarlouski
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 28, 2021 •
edited
Loading

Codecov Report

Merging #1755 (c863962) into master (95b2412) will increase coverage by 0.00%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1755   +/-   ##
=========================================
  Coverage     95.84%   95.85%           
- Complexity     5113     5122    +9     
=========================================
  Files           716      720    +4     
  Lines         14698    14728   +30     
  Branches       1003     1003           
=========================================
+ Hits          14088    14117   +29     
- Misses          475      476    +1     
  Partials        135      135
Impacted Files Coverage Δ
...selenium/cloud/AbstractCloudTestLinkPublisher.java 94.28% <83.33%> (-5.72%) ⬇️
...selenium/cloud/AbstractCloudTestStatusManager.java 92.85% <100.00%> (+3.96%) ⬆️
...vividus/selenium/cloud/CloudTestStatusMapping.java 100.00% <100.00%> (ø)
...us/browserstack/BrowserStackTestLinkPublisher.java 100.00% <100.00%> (ø)
...us/browserstack/BrowserStackTestStatusManager.java 100.00% <100.00%> (ø)
...idus/crossbrowsertesting/CbtTestLinkPublisher.java 100.00% <100.00%> (ø)
...idus/crossbrowsertesting/CbtTestStatusManager.java 100.00% <100.00%> (ø)
...crossbrowsertesting/CbtCapabilitiesConfigurer.java 100.00% <100.00%> (ø)
...ividus/lambdatest/LambdaTestTestLinkPublisher.java 100.00% <100.00%> (ø)
...ividus/lambdatest/LambdaTestTestStatusManager.java 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b2412...c863962. Read the comment docs.

@uarlouski uarlouski marked this pull request as ready for review June 28, 2021 13:46
valfirst
valfirst requested changes Jun 28, 2021
View reviewed changes
docs/modules/plugins/nav.adoc Outdated Show resolved Hide resolved
docs/modules/plugins/pages/plugin-cross-browser-testing.adoc Outdated Show resolved Hide resolved
vividus-plugin-crossbrowsertesting/build.gradle Show resolved Hide resolved
...-crossbrowsertesting/src/main/java/org/vividus/crossbrowsertesting/CBTTestLinkPublisher.java Outdated Show resolved Hide resolved
...-crossbrowsertesting/src/main/java/org/vividus/crossbrowsertesting/CBTTestStatusManager.java Outdated Show resolved Hide resolved
...esting/src/main/java/org/vividus/selenium/crossbrowsertesting/CBTCapabilitiesConfigurer.java Outdated Show resolved Hide resolved
vividus-tests/build.gradle Show resolved Hide resolved
...ension-selenium/src/main/java/org/vividus/selenium/cloud/AbstractCloudTestStatusManager.java Outdated Show resolved Hide resolved
@ikalinin1
Copy link
Member

Please add system test

@uarlouski
Copy link
Member Author

Please add system test

Please provide an account for that

@uarlouski uarlouski requested a review from valfirst June 29, 2021 09:29
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.0% 96.0% Coverage
0.0% 0.0% Duplication

@uarlouski uarlouski requested a review from valfirst June 29, 2021 13:29
@valfirst valfirst merged commit eb586eb into master Jun 29, 2021
@valfirst valfirst deleted the cbt branch June 29, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst approved these changes

@ikalinin1 ikalinin1 ikalinin1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uarlouski @ikalinin1 @valfirst