[vividus-to-zephyr-exporter] Fix validation for zephyr.exporter.source-directory #3044
Conversation
VolhaHurynovich
requested review from
valfirst,
ikalinin1 and
uarlouski
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3044 +/- ##
=========================================
Coverage 96.81% 96.81%
Complexity 5870 5870
=========================================
Files 825 825
Lines 16658 16658
Branches 1076 1076
=========================================
Hits 16127 16127
Misses 419 419
Partials 112 112
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @ConfigurationProperties("zephyr.exporter") | ||
| public class ZephyrExporterProperties | ||
| { | ||
| private String jiraInstanceKey; | ||
|
|
||
| @NotBlank(message = "Property 'zephyr.exporter.source-directory' must not be blank") | ||
| @NotNull(message = "Property 'zephyr.exporter.source-directory' must be set") |
There was a problem hiding this comment.
how does this change fix the issue?
There was a problem hiding this comment.
It helps when property is empty, but in case of a non-existent path, we are facing with NoSuchFileException (just like now)
Property is empty:
Non-existent path:
There was a problem hiding this comment.
If we want to see clear message, I can add try-catch:
try
{
Files.walkFileTree(zephyrExporterProperties.getSourceDirectory(), crawler);
}
catch (IOException e)
{
throw new NoSuchFileException("Path to directory with test execution JSON results should be corrected: "
+ zephyrExporterProperties.getSourceDirectory());
}
or create new annotation @FileByPathExists
|
Kudos, SonarCloud Quality Gate passed!
|
Fixes #3040