Browser console logs #3092
Merged
Browser console logs #3092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3092 +/- ##
============================================
- Coverage 89.36% 89.35% -0.01%
Complexity 6112 6112
============================================
Files 825 825
Lines 16721 16717 -4
Branches 1082 1081 -1
============================================
- Hits 14942 14938 -4
Misses 1648 1648
Partials 131 131
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
uarlouski
reviewed
Aug 22, 2022
vividus-plugin-web-app/src/main/java/org/vividus/selenium/logging/BrowserLogManager.java
Show resolved
Hide resolved
valfirst
requested changes
Aug 23, 2022
|
|
||
| === Browser logs steps | ||
|
|
||
| This set of steps allows you to validate the https://developer.mozilla.org/en-US/docs/Web/API/console[browser's console logging messages]. |
There was a problem hiding this comment.
Suggested change
| This set of steps allows you to validate the https://developer.mozilla.org/en-US/docs/Web/API/console[browser's console logging messages]. | |
| This set of steps allows to validate the https://developer.mozilla.org/en-US/docs/Web/API/console[browser console logging messages]. |
|
|
||
| This set of steps allows you to validate the https://developer.mozilla.org/en-US/docs/Web/API/console[browser's console logging messages]. | ||
|
|
||
| :log-levels: List of the comma-separated mesagges' levels. The supported levels are: ERRORS, WARNINGS. |
There was a problem hiding this comment.
Suggested change
| :log-levels: List of the comma-separated mesagges' levels. The supported levels are: ERRORS, WARNINGS. | |
| :log-levels: List of the comma-separated messages levels. The supported levels are: ERRORS, WARNINGS. |
|
|
||
| ==== Validate log entries absence | ||
|
|
||
| Step validates the absence of log entries of desired level in the browser's console. |
There was a problem hiding this comment.
Suggested change
| Step validates the absence of log entries of desired level in the browser's console. | |
| Validates the absence of log entries of the desired level in the browser console. |
|
|
||
| ==== Validate specific log entries absence | ||
|
|
||
| Step validates absence of specific log entries of desired level in the browser's console. |
There was a problem hiding this comment.
Suggested change
| Step validates absence of specific log entries of desired level in the browser's console. | |
| Validates the absence of specific log entries of the desired level in the browser console. |
| Then there are no browser console $logLevels by regex '$pattern' | ||
| ---- | ||
| * `$logLevels` - {log-levels} | ||
| * `$pattern` - The pattern to match log entry message. |
There was a problem hiding this comment.
Suggested change
| * `$pattern` - The pattern to match log entry message. | |
| * `$pattern` - The regular expression to match log entry messages. |
|
|
||
| ==== Validate specific log entries presence | ||
|
|
||
| Step validates the presence of specific log entries of desired level in the browser's console. |
There was a problem hiding this comment.
Suggested change
| Step validates the presence of specific log entries of desired level in the browser's console. | |
| Validates the presence of specific log entries of the desired level in the browser console. |
| Then there are browser console $logLevels by regex '$pattern' | ||
| ---- | ||
| * `$logLevels` - {log-levels} | ||
| * `$pattern` - The pattern to match log entry message. |
There was a problem hiding this comment.
Suggested change
| * `$pattern` - The pattern to match log entry message. | |
| * `$pattern` - The regular expression to match log entry messages. |
|
Kudos, SonarCloud Quality Gate passed! |
valfirst
approved these changes
Aug 24, 2022
uarlouski
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.