Wait for message #3097
Merged
Wait for message #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3097 +/- ##
============================================
- Coverage 96.85% 89.39% -7.47%
- Complexity 5908 6126 +218
============================================
Files 826 826
Lines 16754 16774 +20
Branches 1083 1084 +1
============================================
- Hits 16227 14995 -1232
- Misses 415 1648 +1233
- Partials 112 131 +19
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ikalinin1
force-pushed
the
wait-for-message
branch
5 times, most recently
from
f4a26ab
to
d6d1355
Compare
valfirst
requested changes
Aug 24, 2022
|
|
||
| ==== Wait for message appearence and save | ||
|
|
||
| Waits for the appearance of the message of the expected level which matches regular expression and saves all the messages (including awaited one) of the expected level gathered during the wait to the scoped variable. |
There was a problem hiding this comment.
Suggested change
| Waits for the appearance of the message of the expected level which matches regular expression and saves all the messages (including awaited one) of the expected level gathered during the wait to the scoped variable. | |
| Waits for the appearance of the console log entries with the expected level and which match regular expression and saves all the entries (including awaited ones) of the expected level gathered during the wait to the scoped variable. |
vividus-plugin-web-app/src/main/java/org/vividus/steps/ui/web/JsValidationSteps.java
Outdated
Show resolved
Hide resolved
vividus-plugin-web-app/src/main/java/org/vividus/steps/ui/web/JsValidationSteps.java
Outdated
Show resolved
Hide resolved
Comment on lines
+151
to
+153
| return String.format("appearance of JavaScript %s matching `%s` regex", | ||
| JsValidationSteps.toString(logEntries), regex); |
There was a problem hiding this comment.
how does failure look? how does passed step look?
ikalinin1
force-pushed
the
wait-for-message
branch
from
d6d1355
to
11225e4
Compare
ikalinin1
force-pushed
the
wait-for-message
branch
from
11225e4
to
d9eb302
Compare
|
Kudos, SonarCloud Quality Gate passed! |
valfirst
approved these changes
Aug 25, 2022
uarlouski
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.