-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize plugins configuration #3156
Conversation
@@ -3,8 +3,9 @@ | |||
Plugins are extensible and flexible mechanism for development. New plugin can be developed by | |||
3rd party team and integrated. | |||
|
|||
The plugin configuration should be placed at the `/src/main/resources/spring.xml` path relatively | |||
to the project root. | |||
The configuration for custom plugins that won't be integrated into VIVIDUS due to their specificity should be placed at the `/src/main/resources/spring.xml` path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, renovate example of the xml to highlight the changes.
@@ -3,8 +3,9 @@ | |||
Plugins are extensible and flexible mechanism for development. New plugin can be developed by | |||
3rd party team and integrated. | |||
|
|||
The plugin configuration should be placed at the `/src/main/resources/spring.xml` path relatively | |||
to the project root. | |||
The configuration for custom plugins that won't be integrated into VIVIDUS due to their specificity should be placed at the `/src/main/resources/spring.xml` path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difference between locations is unclear, maybe add some specific examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say we need to introduce the following naming:
- extensions - basement for plugins
- plugins - contain generic features that can be used by multiple projects, it could be either VIVIDUS or external ones
- custom modules - contain project-specific logic (steps, transformers, expressions, etc.), may depend on extensions and/or plugins, may not have dependencies at all, also they may override default behaviour of plugins and extensions if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this classification can be put to the extension points page and should be duplicated for each component
Codecov Report
@@ Coverage Diff @@
## master #3156 +/- ##
=========================================
Coverage 96.85% 96.85%
Complexity 5905 5905
=========================================
Files 833 833
Lines 16772 16772
Branches 1087 1087
=========================================
Hits 16244 16244
Misses 416 416
Partials 112 112
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
62f8548
to
b9a2f30
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
No description provided.