Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize plugins configuration #3156

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Standardize plugins configuration #3156

merged 1 commit into from
Sep 16, 2022

Conversation

uarlouski
Copy link
Member

No description provided.

@uarlouski uarlouski marked this pull request as ready for review September 14, 2022 08:45
@@ -3,8 +3,9 @@
Plugins are extensible and flexible mechanism for development. New plugin can be developed by
3rd party team and integrated.

The plugin configuration should be placed at the `/src/main/resources/spring.xml` path relatively
to the project root.
The configuration for custom plugins that won't be integrated into VIVIDUS due to their specificity should be placed at the `/src/main/resources/spring.xml` path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, renovate example of the xml to highlight the changes.

@@ -3,8 +3,9 @@
Plugins are extensible and flexible mechanism for development. New plugin can be developed by
3rd party team and integrated.

The plugin configuration should be placed at the `/src/main/resources/spring.xml` path relatively
to the project root.
The configuration for custom plugins that won't be integrated into VIVIDUS due to their specificity should be placed at the `/src/main/resources/spring.xml` path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference between locations is unclear, maybe add some specific examples?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say we need to introduce the following naming:

  • extensions - basement for plugins
  • plugins - contain generic features that can be used by multiple projects, it could be either VIVIDUS or external ones
  • custom modules - contain project-specific logic (steps, transformers, expressions, etc.), may depend on extensions and/or plugins, may not have dependencies at all, also they may override default behaviour of plugins and extensions if needed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this classification can be put to the extension points page and should be duplicated for each component

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #3156 (b9a2f30) into master (2e970d2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3156   +/-   ##
=========================================
  Coverage     96.85%   96.85%           
  Complexity     5905     5905           
=========================================
  Files           833      833           
  Lines         16772    16772           
  Branches       1087     1087           
=========================================
  Hits          16244    16244           
  Misses          416      416           
  Partials        112      112           
Impacted Files Coverage Δ
...in/java/org/vividus/configuration/BeanFactory.java 94.28% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@valfirst valfirst merged commit cdfe1d6 into master Sep 16, 2022
@valfirst valfirst deleted the vividus-plugin branch September 16, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants