[vividus] Add ability to set the encryption password via environment variable #3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draker94
requested review from
valfirst,
ikalinin1 and
uarlouski
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3288 +/- ##
============================================
+ Coverage 96.89% 96.90% +0.01%
Complexity 5910 5910
============================================
Files 827 827
Lines 16760 16761 +1
Branches 1089 1087 -2
============================================
+ Hits 16240 16243 +3
+ Misses 412 410 -2
Partials 108 108
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
valfirst
requested changes
Oct 19, 2022
vividus/src/main/java/org/vividus/configuration/ConfigurationResolver.java
Outdated
Show resolved
Hide resolved
draker94
force-pushed
the
set_encrypt_pass_in_env
branch
2 times, most recently
from
ab171f4
to
538d4df
Compare
uarlouski
reviewed
Oct 20, 2022
valfirst
approved these changes
Oct 20, 2022
uarlouski
approved these changes
Oct 20, 2022
|
Please add new integration test to cover the new functionality |
ikalinin1
reviewed
Oct 20, 2022
vividus/src/main/java/org/vividus/configuration/ConfigurationResolver.java
Show resolved
Hide resolved
draker94
force-pushed
the
set_encrypt_pass_in_env
branch
2 times, most recently
from
42fdc9b
to
a8c24d1
Compare
valfirst
approved these changes
Oct 21, 2022
uarlouski
approved these changes
Oct 21, 2022
ikalinin1
reviewed
Oct 21, 2022
vividus/src/integrationTest/java/org/vividus/configuration/BeanFactoryIntegrationTests.java
Show resolved
Hide resolved
draker94
force-pushed
the
set_encrypt_pass_in_env
branch
from
a8c24d1
to
583df60
Compare
draker94
force-pushed
the
set_encrypt_pass_in_env
branch
from
583df60
to
02a882c
Compare
ikalinin1
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.