Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vividus] Allow to escape commas in common expressions #3391

Merged

Conversation

EDbarvinsky
Copy link
Contributor

@EDbarvinsky EDbarvinsky commented Nov 25, 2022

Relates #3256

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #3391 (7e37684) into master (33d3513) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #3391   +/-   ##
=========================================
  Coverage     96.96%   96.96%           
  Complexity     6010     6010           
=========================================
  Files           842      842           
  Lines         17151    17151           
  Branches       1110     1110           
=========================================
  Hits          16631    16631           
  Misses          412      412           
  Partials        108      108           
Impacted Files Coverage Δ
...a/org/vividus/expression/NormalizingArguments.java 100.00% <ø> (ø)
...rg/vividus/expression/HashExpressionProcessor.java 100.00% <100.00%> (ø)
...g/vividus/expression/ReplaceByRegExpProcessor.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@EDbarvinsky EDbarvinsky changed the title [vividus] Add hash expression unit test for argument with commas [vividus] Add expression processors unit tests with arguments with commas Nov 29, 2022
@EDbarvinsky EDbarvinsky force-pushed the 3256_enhace_hash_expression branch 7 times, most recently from 951889f to 2201441 Compare November 30, 2022 20:36
@valfirst valfirst changed the title [vividus] Add expression processors unit tests with arguments with commas [vividus] Allow to escape commas in common expressions Dec 7, 2022
@valfirst valfirst merged commit e6931a8 into vividus-framework:master Dec 8, 2022
@EDbarvinsky EDbarvinsky deleted the 3256_enhace_hash_expression branch March 23, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants