Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile web #3435

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Mobile web #3435

merged 2 commits into from
Dec 9, 2022

Conversation

ikalinin1
Copy link
Member

No description provided.

@ikalinin1 ikalinin1 marked this pull request as draft December 7, 2022 11:39
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #3435 (144049a) into master (7222acf) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3435   +/-   ##
=========================================
  Coverage     96.96%   96.96%           
  Complexity     6013     6013           
=========================================
  Files           842      842           
  Lines         17154    17154           
  Branches       1110     1110           
=========================================
  Hits          16634    16634           
  Misses          412      412           
  Partials        108      108           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ikalinin1 ikalinin1 force-pushed the mobile_web branch 3 times, most recently from d859d2f to 06e8eb7 Compare December 7, 2022 13:52
- name: SauceLabs - Phone - Web - System tests
if: matrix.platform == 'ubuntu-latest'
- name: SauceLabs - Mobile - Web - System tests
if: matrix.platform == 'macos-latest'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to use ubuntu to avoid race conditions

Comment on lines 1 to 2
selenium.grid.capabilities.bstack\:options.deviceName=Samsung Galaxy S22 Ultra
selenium.grid.platform-version=12.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be a part of vividus-tests

Comment on lines 1 to 2
selenium.grid.capabilities.bstack\:options.deviceName=iPhone 14
selenium.grid.platform-version=16
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be a part of vividus-tests

@@ -0,0 +1 @@
selenium.grid.capabilities.bstack\:options.os=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it expected value?

@ikalinin1 ikalinin1 marked this pull request as ready for review December 7, 2022 17:53
@ikalinin1 ikalinin1 force-pushed the mobile_web branch 2 times, most recently from 3631898 to a180a36 Compare December 7, 2022 18:55
@ikalinin1 ikalinin1 force-pushed the mobile_web branch 2 times, most recently from ada5d0d to 77c254b Compare December 8, 2022 08:12
@ikalinin1 ikalinin1 force-pushed the mobile_web branch 2 times, most recently from 583253f to 147b074 Compare December 8, 2022 15:29
@ikalinin1 ikalinin1 force-pushed the mobile_web branch 2 times, most recently from 7eb5f7c to 8fa5a55 Compare December 9, 2022 08:40
@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@valfirst valfirst merged commit 3c6164e into master Dec 9, 2022
@valfirst valfirst deleted the mobile_web branch December 9, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants