Add support of “is not equal to” comparison rule for json steps with null value #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VolhaHurynovich
requested review from
valfirst,
ikalinin1 and
uarlouski
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3456 +/- ##
============================================
- Coverage 96.96% 96.95% -0.02%
- Complexity 6013 6014 +1
============================================
Files 842 842
Lines 17154 17158 +4
Branches 1110 1112 +2
============================================
+ Hits 16634 16635 +1
- Misses 412 414 +2
- Partials 108 109 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
valfirst
requested changes
Dec 12, 2022
vividus-plugin-json/src/main/java/org/vividus/json/steps/JsonSteps.java
Outdated
Show resolved
Hide resolved
vividus-plugin-json/src/main/java/org/vividus/json/steps/JsonSteps.java
Outdated
Show resolved
Hide resolved
vividus-plugin-json/src/main/java/org/vividus/json/steps/JsonSteps.java
Outdated
Show resolved
Hide resolved
vividus-plugin-json/src/main/java/org/vividus/json/steps/JsonSteps.java
Outdated
Show resolved
Hide resolved
vividus-plugin-json/src/main/java/org/vividus/json/steps/JsonSteps.java
Outdated
Show resolved
Hide resolved
VolhaHurynovich
force-pushed
the
nullRule
branch
from
59a8b26
to
fe661fd
Compare
valfirst
reviewed
Dec 13, 2022
vividus-plugin-json/src/main/java/org/vividus/json/steps/JsonSteps.java
Outdated
Show resolved
Hide resolved
…e for json steps with null value
VolhaHurynovich
force-pushed
the
nullRule
branch
from
f45f134
to
056e80e
Compare
|
Kudos, SonarCloud Quality Gate passed! |
ikalinin1
approved these changes
Dec 14, 2022
uarlouski
reviewed
Dec 14, 2022
uarlouski
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.