[vividus] Fix generate expression to be thread-safe again
#3509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root cause of the fixed issue: datafaker-net/datafaker#574. It's needed to use JitPack build, because new `datafaker` release is not plublished and timeline is unknown (see more: datafaker-net/datafaker#574 (comment)). `datafaker` SNAPSHOT builds may introduce unexpected breaking changes e.g. datafaker-net/datafaker@e44736d, that's why they are not acceptable.
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #3509 +/- ##
=========================================
Coverage 96.97% 96.97%
Complexity 6015 6015
=========================================
Files 842 842
Lines 17162 17162
Branches 1112 1112
=========================================
Hits 16642 16642
Misses 412 412
Partials 108 108 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
uarlouski
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of the fixed issue: datafaker-net/datafaker#574. It's needed to use JitPack build, because new
datafakerrelease is not plublished and timeline is unknown (see more: datafaker-net/datafaker#574 (comment)).datafakerSNAPSHOT builds may introduce unexpected breaking changes e.g. datafaker-net/datafaker@e44736d, that's why they are not acceptable.