Update syntax for "When I go to the relative URL '$relativeURL'" step #3516

vkepin · 2023-01-02T12:56:28Z

No description provided.

docs/modules/plugins/partials/plugin-web-app-steps.adoc

valfirst

Also please fix spotless violations

valfirst · 2023-01-03T06:53:53Z

docs/modules/plugins/partials/plugin-web-app-steps.adoc

@@ -2,6 +2,24 @@
 :popup-alert: https://www.w3schools.com/js/js_popup.asp
 :close-spec: https://w3c.github.io/webdriver/webdriver-spec.html#close-window[close]

+=== Page steps


Suggested change

=== Page steps

=== Steps opening pages

valfirst · 2023-01-03T06:54:27Z

docs/modules/plugins/partials/plugin-web-app-steps.adoc

+
+==== Go to relative URL
+
+A _relative URL_ - points to a file within a web site (like `about.html` or `/products`)


too technical

PS: javadocs may not be a good example to copy

valfirst · 2023-01-03T06:55:04Z

docs/modules/plugins/partials/plugin-web-app-steps.adoc

+
+Actions performed at this step:
+
+* Builds the absolute URL by concatenating the base URL and the relative URL;


not clear what source of the base URL is

valfirst · 2023-01-03T06:55:20Z

docs/modules/plugins/partials/plugin-web-app-steps.adoc

+----
+
+* `relativeURL` - A string value of the relative URL
+


also please add example demoing step usage

still looking for examples

codecov · 2023-01-03T13:29:39Z

Codecov Report

Merging #3516 (99cfcb9) into master (2047e3d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3516   +/-   ##
=========================================
  Coverage     96.96%   96.96%           
  Complexity     6046     6046           
=========================================
  Files           848      848           
  Lines         17280    17280           
  Branches       1122     1122           
=========================================
  Hits          16756    16756           
  Misses          417      417           
  Partials        107      107

Impacted Files	Coverage Δ
.../main/java/org/vividus/steps/ui/web/PageSteps.java	`98.80% <ø> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ikalinin1 · 2023-01-03T14:30:32Z

vividus-plugin-web-app/src/main/resources/steps/defaults/composite.steps

+
+Composite: When I go to the relative URL '$relativeURL'
+!-- WARNING: The step "When I go to the relative URL '$relativeURL'" is deprecated and will be removed in VIVIDUS 0.7.0
+When I go to relative URL `<$relativeURL>`


Suggested change

When I go to relative URL `<$relativeURL>`

When I go to relative URL `<relativeURL>`

uarlouski · 2023-01-04T08:24:34Z

docs/modules/plugins/partials/plugin-web-app-steps.adoc

+
+==== Go to relative URL
+
+Navigates the browser to the specific path in the host defined in the _relative URL_ step variable.


"to the specific path in the host" this statement is not clear

uarlouski · 2023-01-04T08:26:53Z

vividus-plugin-web-app/src/main/java/org/vividus/steps/ui/web/PageSteps.java

@@ -248,7 +248,7 @@ public void isPageScrolledToAnElement(Locator locator)
 * <p>
 * @param relativeURL A string value of the relative URL
 */
- @When("I go to the relative URL '$relativeURL'")
+ @When("I go to relative URL `$relativeURL`")
 public void iGoTo(String relativeURL)


I think it makes sense to give the method clearer name

changed to 'openRelativeUrl'

uarlouski · 2023-01-04T08:27:40Z

vividus-plugin-web-app/src/main/java/org/vividus/steps/ui/web/PageSteps.java

@@ -248,7 +248,7 @@ public void isPageScrolledToAnElement(Locator locator)
 * <p>
 * @param relativeURL A string value of the relative URL
 */


please don't forget to sync javadoc with main docs

valfirst · 2023-01-04T08:26:26Z

docs/modules/plugins/partials/plugin-web-app-steps.adoc

@@ -2,6 +2,43 @@
 :popup-alert: https://www.w3schools.com/js/js_popup.asp
 :close-spec: https://w3c.github.io/webdriver/webdriver-spec.html#close-window[close]

+=== Steps opening pages
+
+==== Go to relative URL


Suggested change

==== Go to relative URL

==== Open page with relative URL

valfirst · 2023-01-04T08:26:51Z

docs/modules/plugins/partials/plugin-web-app-steps.adoc

+
+==== Go to relative URL
+
+Navigates the browser to the specific path in the host defined in the _relative URL_ step variable.


Suggested change

Navigates the browser to the specific path in the host defined in the _relative URL_ step variable.

Navigates the browser to the specific path in the host defined in the _relative URL_ step parameter.

valfirst · 2023-01-04T08:28:18Z

docs/modules/plugins/partials/plugin-web-app-steps.adoc

+Navigates the browser to the specific path in the host defined in the _relative URL_ step variable.
+
+A relative URL can point to a file within a website (like `about.html` or `/products`).
+If the parameter starts with '/' char, navigation will be performed from the root of the host, see examples below.


what about case like ./about.html?

valfirst · 2023-01-04T08:28:42Z

docs/modules/plugins/partials/plugin-web-app-steps.adoc

+----
+
+* `relativeURL` - A string value of the relative URL
+


still looking for examples

valfirst · 2023-01-04T08:29:48Z

vividus-plugin-web-app/src/main/resources/steps/defaults/composite.steps

@@ -284,3 +284,7 @@ When I wait until element located by `<locator>` contains text `<text>'
 Composite: Then element located '$locator' disappears in '$timeout'
 !-- WARNING: The step "Then element located '$locator' disappears in '$timeout'" is deprecated and will be removed in VIVIDUS 0.6.0
 Then element located by `<locator>` disappears in `<timeout>`
+
+Composite: When I go to the relative URL '$relativeURL'


we need to have tests for both new and deprecated steps, so please either add new test or change some existing one to check behaviour of the new step

docs/modules/plugins/partials/plugin-web-app-steps.adoc

Co-authored-by: Ivan Kalinin <ivan_kalinin1@epam.com>

vkepin requested review from valfirst, ikalinin1 and uarlouski as code owners January 2, 2023 12:56

vkepin commented Jan 2, 2023

View reviewed changes

docs/modules/plugins/partials/plugin-web-app-steps.adoc Outdated Show resolved Hide resolved

valfirst requested changes Jan 3, 2023

View reviewed changes

vkepin force-pushed the gotoRelativeUrl branch from 6751023 to 7b90b26 Compare January 3, 2023 13:02

vkepin force-pushed the gotoRelativeUrl branch from 7b90b26 to 992bfa5 Compare January 3, 2023 14:13

ikalinin1 reviewed Jan 3, 2023

View reviewed changes

vkepin force-pushed the gotoRelativeUrl branch 2 times, most recently from ce011ba to 0f11229 Compare January 3, 2023 14:38

uarlouski reviewed Jan 4, 2023

View reviewed changes

valfirst requested changes Jan 4, 2023

View reviewed changes

vkepin force-pushed the gotoRelativeUrl branch 5 times, most recently from 3c69425 to 44bce3d Compare January 9, 2023 10:02

ikalinin1 reviewed Jan 9, 2023

View reviewed changes

docs/modules/plugins/partials/plugin-web-app-steps.adoc Outdated Show resolved Hide resolved

ikalinin1 approved these changes Jan 9, 2023

View reviewed changes

ikalinin1 requested review from uarlouski and valfirst January 10, 2023 07:26

vkepin force-pushed the gotoRelativeUrl branch 2 times, most recently from b72c51b to 77d5123 Compare January 10, 2023 11:57

Update syntax for "When I go to the relative URL '$relativeURL'" step

6024e3d

vkepin force-pushed the gotoRelativeUrl branch from 77d5123 to 6024e3d Compare January 10, 2023 18:52

valfirst and others added 2 commits January 11, 2023 11:20

Update docs/modules/plugins/partials/plugin-web-app-steps.adoc

e14aeda

Co-authored-by: Ivan Kalinin <ivan_kalinin1@epam.com>

Improve integration tests performance

99cfcb9

valfirst approved these changes Jan 11, 2023

View reviewed changes

valfirst merged commit 4b3df98 into vividus-framework:master Jan 11, 2023

vkepin deleted the gotoRelativeUrl branch April 24, 2023 15:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update syntax for "When I go to the relative URL '$relativeURL'" step #3516

Update syntax for "When I go to the relative URL '$relativeURL'" step #3516

vkepin commented Jan 2, 2023

valfirst left a comment

valfirst Jan 3, 2023

valfirst Jan 3, 2023

valfirst Jan 3, 2023

valfirst Jan 3, 2023

vkepin Jan 4, 2023

valfirst Jan 4, 2023

vkepin Jan 5, 2023

codecov bot commented Jan 3, 2023 •

edited

Loading

ikalinin1 Jan 3, 2023

uarlouski Jan 4, 2023

uarlouski Jan 4, 2023

vkepin Jan 10, 2023

uarlouski Jan 4, 2023

vkepin Jan 5, 2023

valfirst Jan 4, 2023

valfirst Jan 4, 2023

valfirst Jan 4, 2023

valfirst Jan 4, 2023

valfirst Jan 4, 2023

vkepin Jan 5, 2023


		==== Go to relative URL

		A _relative URL_ - points to a file within a web site (like `about.html` or `/products`)


		Actions performed at this step:

		* Builds the absolute URL by concatenating the base URL and the relative URL;

	When I go to relative URL `<$relativeURL>`
	When I go to relative URL `<relativeURL>`


		==== Go to relative URL

		Navigates the browser to the specific path in the host defined in the _relative URL_ step variable.

Update syntax for "When I go to the relative URL '$relativeURL'" step #3516

Update syntax for "When I go to the relative URL '$relativeURL'" step #3516

Conversation

vkepin commented Jan 2, 2023

valfirst left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jan 3, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jan 3, 2023 •

edited

Loading