[engine] Align story execution timeout properties naming #3531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3531 +/- ##
============================================
+ Coverage 89.31% 96.95% +7.64%
+ Complexity 6236 6025 -211
============================================
Files 844 844
Lines 17186 17198 +12
Branches 1119 1121 +2
============================================
+ Hits 15349 16674 +1325
+ Misses 1710 417 -1293
+ Partials 127 107 -20
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
valfirst
reviewed
Jan 6, 2023
vividus-engine/src/main/java/org/vividus/batch/BatchStorage.java
Outdated
Show resolved
Hide resolved
uarlouski
reviewed
Jan 6, 2023
valfirst
requested changes
Jan 9, 2023
valfirst
reviewed
Jan 9, 2023
Comment on lines
62
to
63
| this.defaultStoryExecutionTimeout = defaultStoryExecutionTimeout == null ? DEFAULT_STORY_TIMEOUT | ||
| : defaultStoryExecutionTimeout; |
There was a problem hiding this comment.
optional comment:
Suggested change
| this.defaultStoryExecutionTimeout = defaultStoryExecutionTimeout == null ? DEFAULT_STORY_TIMEOUT | |
| : defaultStoryExecutionTimeout; | |
| this.defaultStoryExecutionTimeout = Optional.ofNullable(defaultStoryExecutionTimeout).orElse(DEFAULT_STORY_TIMEOUT); |
valfirst
approved these changes
Jan 9, 2023
|
Kudos, SonarCloud Quality Gate passed! |
uarlouski
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3416