[plugin-web-app] Record failed assertion for intercepted click #3601
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3601 +/- ##
============================================
- Coverage 96.98% 96.98% -0.01%
+ Complexity 6068 6067 -1
============================================
Files 855 855
Lines 17350 17349 -1
Branches 1123 1122 -1
============================================
- Hits 16827 16826 -1
Misses 417 417
Partials 106 106
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
draker94
force-pushed
the
add_assertion_for_intercepted_click
branch
from
ddfb96d
to
5fe1eaa
Compare
| { | ||
| javascriptActions.click(element); | ||
| softAssert.recordFailedAssertion(COULD_NOT_CLICK_ERROR_MESSAGE + webDriverException); |
There was a problem hiding this comment.
Why are you appending an exception? What is the resulting error?
org.vividus.softassert.SoftAssert#recordFailedAssertion(java.lang.String, java.lang.Throwable)
There was a problem hiding this comment.
What is the resulting error?
Why are you appending an exception?
It has pretty enough information about the error
org.vividus.softassert.SoftAssert#recordFailedAssertion(java.lang.String, java.lang.Throwable)
I think previous way (see previous pic) in the result more readable
There was a problem hiding this comment.
IMHO you should record the exception with stacktrace
There was a problem hiding this comment.
for this case that's doubtful, stack trace won't give any useful information
There was a problem hiding this comment.
In any case, we can expand error in Allure for stack trace
There was a problem hiding this comment.
Since you all agree on the matter, it is up to you how to deal with the stacktrace. However, that doesn't explain why you are appending an exception instead of its message
There was a problem hiding this comment.
why you are appending an exception instead of its message
🙂
There was a problem hiding this comment.
Yep, is it useful for the user to have the class name in error?
No description provided.