Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin-web-app] Improve buttonName locator to search button text in child elements #3621

Conversation

valfirst
Copy link
Collaborator

@valfirst valfirst commented Feb 7, 2023

No description provided.

@valfirst valfirst requested a review from a team as a code owner February 7, 2023 19:56
@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #3621 (257fb5d) into master (e01000c) will decrease coverage by 7.54%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3621      +/-   ##
============================================
- Coverage     96.99%   89.45%   -7.54%     
- Complexity     6091     6303     +212     
============================================
  Files           856      856              
  Lines         17414    17414              
  Branches       1132     1132              
============================================
- Hits          16891    15578    -1313     
- Misses          417     1710    +1293     
- Partials        106      126      +20     
Impacted Files Coverage Δ
...vividus/ui/web/action/search/ButtonNameSearch.java 100.00% <ø> (ø)
.../src/main/java/org/vividus/results/model/Node.java 0.00% <0.00%> (-100.00%) ⬇️
...rc/main/java/org/vividus/transformer/JoinMode.java 0.00% <0.00%> (-100.00%) ⬇️
...c/main/java/org/vividus/transformer/MergeMode.java 0.00% <0.00%> (-100.00%) ⬇️
.../main/java/org/vividus/runner/BddStepsCounter.java 0.00% <0.00%> (-100.00%) ⬇️
...in/java/org/vividus/results/model/NodeContext.java 0.00% <0.00%> (-100.00%) ⬇️
...n/java/org/vividus/runner/BddScenariosCounter.java 0.00% <0.00%> (-100.00%) ⬇️
...n/java/org/vividus/runner/KnownIssueValidator.java 0.00% <0.00%> (-100.00%) ⬇️
...g/vividus/runner/VividusInitializationChecker.java 0.00% <0.00%> (-100.00%) ⬇️
.../vividus/runner/InvalidConfigurationException.java 0.00% <0.00%> (-100.00%) ⬇️
... and 59 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@valfirst valfirst merged commit 70e6229 into master Feb 8, 2023
@valfirst valfirst deleted the improve-buttonName-locator-to-search-button-text-in-child-elements branch February 8, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants