Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin-ssh] Avoid using empty string as result for SFTP commands not providing any result #3662

Conversation

valfirst
Copy link
Collaborator

Closes #2843

@valfirst valfirst requested a review from a team as a code owner February 21, 2023 11:50
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #3662 (3301a6c) into master (a6b6f7c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #3662   +/-   ##
=========================================
  Coverage     96.97%   96.97%           
- Complexity     6094     6097    +3     
=========================================
  Files           860      860           
  Lines         17447    17450    +3     
  Branches       1137     1137           
=========================================
+ Hits          16920    16923    +3     
  Misses          422      422           
  Partials        105      105           
Impacted Files Coverage Δ
...src/main/java/org/vividus/ssh/sftp/SftpOutput.java 100.00% <ø> (ø)
...in-ssh/src/main/java/org/vividus/ssh/SshSteps.java 100.00% <100.00%> (ø)
...c/main/java/org/vividus/ssh/sftp/SftpExecutor.java 100.00% <100.00%> (ø)
...java/org/vividus/ssh/sftp/SftpOutputPublisher.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@valfirst valfirst force-pushed the avoid-using-empty-string-as-result-of-sftp-commands-which-do-not-provide-results branch from 834f231 to 3301a6c Compare February 21, 2023 14:25
@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@valfirst valfirst merged commit 010f35f into master Feb 21, 2023
@valfirst valfirst deleted the avoid-using-empty-string-as-result-of-sftp-commands-which-do-not-provide-results branch February 21, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When I create file with content at path over SFTP does not display content of created file
3 participants