Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[engine] Resolve identical Jbehave story names #3666

Merged
merged 1 commit into from
Mar 9, 2023
Merged

[engine] Resolve identical Jbehave story names #3666

merged 1 commit into from
Mar 9, 2023

Conversation

draker94
Copy link
Contributor

@draker94 draker94 commented Feb 24, 2023 •
edited
Loading

Closes #3607

@draker94 draker94 marked this pull request as ready for review February 24, 2023 15:43
@draker94 draker94 requested a review from a team as a code owner February 24, 2023 15:43
@draker94 draker94 marked this pull request as draft February 28, 2023 15:47
@draker94 draker94 force-pushed the add_same_name_story_resolver branch 2 times, most recently from 2b06e1b to 9daaba1 Compare February 28, 2023 16:12
@codecov
Copy link

codecov bot commented Feb 28, 2023 •
edited
Loading

Codecov Report

Merging #3666 (d9f4481) into master (bb9562e) will decrease coverage by 0.01%.
The diff coverage is 94.91%.

@@             Coverage Diff              @@
##             master    #3666      +/-   ##
============================================
- Coverage     96.97%   96.97%   -0.01%     
+ Complexity     6309     6122     -187     
============================================
  Files           860      862       +2     
  Lines         17441    17513      +72     
  Branches       1136     1144       +8     
============================================
+ Hits          16914    16983      +69     
- Misses          422      423       +1     
- Partials        105      107       +2
Impacted Files Coverage Δ
.../java/org/vividus/IdenticalStoryNamesResolver.java 92.10% <92.10%> (ø)
.../main/java/org/vividus/BatchedPerformableTree.java 88.88% <100.00%> (+7.07%) ⬆️
...in/java/org/vividus/ResolveToUniqueSimpleName.java 100.00% <100.00%> (ø)
.../main/java/org/vividus/steps/kafka/KafkaSteps.java 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@draker94 draker94 marked this pull request as ready for review February 28, 2023 16:49
@draker94 draker94 force-pushed the add_same_name_story_resolver branch 2 times, most recently from a7001f2 to 17d21b5 Compare March 1, 2023 08:03
@draker94 draker94 force-pushed the add_same_name_story_resolver branch from 17d21b5 to ea7c4b3 Compare March 2, 2023 12:41
@ikalinin1
Copy link
Member

@draker94 please share report example

@draker94
Copy link
Contributor Author

draker94 commented Mar 2, 2023 •
edited
Loading

@draker94 please share report example

@ikalinin1
reports3666.zip
You can also check new stories from the current PR reports

@draker94 draker94 force-pushed the add_same_name_story_resolver branch from ea7c4b3 to 908f3df Compare March 2, 2023 15:50
@valfirst valfirst self-requested a review March 3, 2023 07:37
@ikalinin1
Copy link
Member

@draker94 please share report example

@ikalinin1 reports3666.zip You can also check new stories from the current PR reports

Currently in the report story and the batch definition uses a different path separator, please consider refactoring to have the same separator in both places

image

image

we need to use "/" for consistency in all cases

@draker94 draker94 force-pushed the add_same_name_story_resolver branch from 908f3df to 2da19a4 Compare March 3, 2023 11:09
@draker94
Copy link
Contributor Author

draker94 commented Mar 3, 2023 •
edited
Loading

@ikalinin1
New report with the fix.
In addition, store names are now resolved only relative to the current batch.
reports3666-1.zip

P.S. Unfortunately on Linux we cannot test the functionality related to the replacement of separators. This only possible with additional dependencies (for example Jimfs)

@draker94 draker94 force-pushed the add_same_name_story_resolver branch from 2da19a4 to a347489 Compare March 3, 2023 13:53
@draker94 draker94 force-pushed the add_same_name_story_resolver branch from a347489 to d9f4481 Compare March 3, 2023 15:22
@valfirst valfirst merged commit b0ac788 into vividus-framework:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst approved these changes

@ikalinin1 ikalinin1 ikalinin1 approved these changes

@uarlouski uarlouski Awaiting requested review from uarlouski uarlouski is a code owner automatically assigned from vividus-framework/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stories with the same name but different paths are displayed as one in Allure
4 participants
@draker94 @ikalinin1 @valfirst @web-flow