[plugin-kafka] Aligh syntax with the official documentation #3682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3682 +/- ##
==========================================
Coverage 96.97% 96.97%
+ Complexity 6309 6092 -217
==========================================
Files 860 860
Lines 17441 17447 +6
Branches 1136 1136
==========================================
+ Hits 16914 16920 +6
Misses 422 422
Partials 105 105
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
valfirst
requested changes
Feb 27, 2023
ikalinin1
reviewed
Feb 27, 2023
ikalinin1
reviewed
Feb 27, 2023
uarlouski
force-pushed
the
kafka-syntax-alignment
branch
from
531a07a
to
885182a
Compare
ikalinin1
approved these changes
Feb 28, 2023
uarlouski
force-pushed
the
kafka-syntax-alignment
branch
from
885182a
to
828c743
Compare
ikalinin1
reviewed
Feb 28, 2023
|
|
||
| .Deprecated syntax |
There was a problem hiding this comment.
i think it is better to put the new syntax before the old one
There was a problem hiding this comment.
Agree, but I copied this from another place, so probably it makes sense to do it in a separate commit
valfirst
requested changes
Feb 28, 2023
vividus-plugin-kafka/src/main/java/org/vividus/steps/kafka/KafkaSteps.java
Outdated
Show resolved
Hide resolved
uarlouski
force-pushed
the
kafka-syntax-alignment
branch
from
828c743
to
ddc12f1
Compare
valfirst
requested changes
Feb 28, 2023
vividus-plugin-kafka/src/main/java/org/vividus/steps/kafka/KafkaSteps.java
Outdated
Show resolved
Hide resolved
uarlouski
force-pushed
the
kafka-syntax-alignment
branch
from
ddc12f1
to
abec3c4
Compare
ikalinin1
reviewed
Feb 28, 2023
vividus-plugin-kafka/src/main/java/org/vividus/steps/kafka/KafkaSteps.java
Show resolved
Hide resolved
ikalinin1
reviewed
Feb 28, 2023
Comment on lines
214
to
215
| () -> getEventsBy(consumerKey).size(), | ||
| countMatcher::matches); |
There was a problem hiding this comment.
Suggested change
| () -> getEventsBy(consumerKey).size(), | |
| countMatcher::matches); | |
| () -> getEventsBy(consumerKey).size(), countMatcher::matches); |
There was a problem hiding this comment.
optional, just looks strange to me :)
ikalinin1
approved these changes
Feb 28, 2023
valfirst
approved these changes
Feb 28, 2023
uarlouski
force-pushed
the
kafka-syntax-alignment
branch
from
e11341a
to
6dca766
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.