Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin-web-app] Add workaround for Chrome 111 #3708

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

valfirst
Copy link
Collaborator

@valfirst valfirst commented Mar 9, 2023

Root cause is the changes in Chrome behavior: https://bugs.chromium.org/p/chromium/issues/detail?id=1422444
Discussion: https://groups.google.com/g/chromedriver-users/c/xL5-13_qGaA?pli=1
Selenium issue: SeleniumHQ/selenium#11750

Solution details: following Selenium team recommendation and switching to JDK 11 Http client for Selenium

Root cause is the changes in Chrome behavior: https://bugs.chromium.org/p/chromium/issues/detail?id=1422444
Discussion: https://groups.google.com/g/chromedriver-users/c/xL5-13_qGaA?pli=1
Selenium issue: SeleniumHQ/selenium#11750

Solution details: following Selenium team recommendation and switching to JDK 11 Http client for Selenium
@valfirst valfirst requested a review from a team as a code owner March 9, 2023 09:49
@valfirst valfirst requested review from ikalinin1 and uarlouski March 9, 2023 09:49
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #3708 (b4d0b71) into master (b0ac788) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3708      +/-   ##
============================================
- Coverage     96.97%   96.97%   -0.01%     
  Complexity     6122     6122              
============================================
  Files           862      862              
  Lines         17513    17513              
  Branches       1144     1144              
============================================
- Hits          16984    16983       -1     
- Misses          422      423       +1     
  Partials        107      107              
Impacted Files Coverage Δ
.../java/org/vividus/IdenticalStoryNamesResolver.java 92.10% <0.00%> (-2.64%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@valfirst valfirst merged commit 656ed89 into master Mar 10, 2023
@valfirst valfirst deleted the add-workaround-for-chrome-111 branch March 10, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants