Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vividus] Add INNER_JOIN table transformer #3709

Merged
merged 1 commit into from
Mar 22, 2023
Merged

[vividus] Add INNER_JOIN table transformer #3709

merged 1 commit into from
Mar 22, 2023

Conversation

VolhaHurynovich
Copy link
Contributor

@VolhaHurynovich VolhaHurynovich commented Mar 9, 2023 •
edited by valfirst
Loading

Closes #1810

@VolhaHurynovich VolhaHurynovich requested a review from a team as a code owner March 9, 2023 10:19
@VolhaHurynovich VolhaHurynovich linked an issue Mar 9, 2023 that may be closed by this pull request
Add "inner join" table transformer #1810
Closed
@codecov
Copy link

codecov bot commented Mar 9, 2023 •
edited
Loading

Codecov Report

Merging #3709 (2e73e92) into master (bb563f5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #3709   +/-   ##
=========================================
  Coverage     96.96%   96.96%           
  Complexity     6085     6085           
=========================================
  Files           856      857    +1     
  Lines         17405    17438   +33     
  Branches       1134     1136    +2     
=========================================
+ Hits          16876    16908   +32     
- Misses          422      423    +1     
  Partials        107      107
Impacted Files Coverage Δ
...vividus/transformer/InnerJoinTableTransformer.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

valfirst
valfirst requested changes Mar 10, 2023
View reviewed changes
docs/modules/commons/pages/table-transformers.adoc Outdated Show resolved Hide resolved
docs/modules/commons/pages/table-transformers.adoc Outdated Show resolved Hide resolved
docs/modules/commons/pages/table-transformers.adoc Outdated Show resolved Hide resolved
docs/modules/commons/pages/table-transformers.adoc Outdated Show resolved Hide resolved
docs/modules/commons/pages/table-transformers.adoc Outdated Show resolved Hide resolved
vividus/src/main/java/org/vividus/transformer/InnerJoinTableTransformer.java Outdated Show resolved Hide resolved
vividus/src/main/java/org/vividus/transformer/InnerJoinTableTransformer.java Outdated Show resolved Hide resolved
vividus/src/main/java/org/vividus/transformer/InnerJoinTableTransformer.java Outdated Show resolved Hide resolved
vividus/src/main/java/org/vividus/transformer/InnerJoinTableTransformer.java Outdated Show resolved Hide resolved
vividus/src/test/java/org/vividus/transformer/InnerJoinTableTransformerTests.java Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@valfirst valfirst merged commit 85c13b6 into master Mar 22, 2023
@valfirst valfirst deleted the 1810 branch March 22, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst approved these changes

@ikalinin1 ikalinin1 ikalinin1 approved these changes

@uarlouski uarlouski uarlouski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "inner join" table transformer
4 participants
@VolhaHurynovich @valfirst @ikalinin1 @uarlouski