[plugin-mobile-app] Add step to download the file from the device and… #3749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3749 +/- ##
============================================
- Coverage 96.99% 96.98% -0.01%
- Complexity 6082 6085 +3
============================================
Files 854 854
Lines 17425 17434 +9
Branches 1136 1136
============================================
+ Hits 16901 16909 +8
- Misses 418 419 +1
Partials 106 106
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ikalinin1
approved these changes
Mar 23, 2023
valfirst
requested changes
Mar 24, 2023
| When I download file `$filePath` from device and save its content to $scopes variable `$variableName` | ||
| ---- | ||
|
|
||
| include::partial$mobile-remote-file-path.adoc[] |
There was a problem hiding this comment.
the description for $scopes and $variableName is missing
| @@ -78,4 +79,19 @@ public void rotate(ScreenOrientation orientation) | |||
| webDriverSessionInfo.reset(WebDriverSessionAttributes.SCREEN_SIZE); | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Pull a file by <b>deviceFilePath</b> from the device | |||
There was a problem hiding this comment.
Suggested change
| * Pull a file by <b>deviceFilePath</b> from the device | |
| * Pull a file at <b>deviceFilePath</b> from the device |
|
|
||
| /** | ||
| * Pull a file by <b>deviceFilePath</b> from the device | ||
| * @param deviceFilePath The path to an existing remote file on the device. This variable can be predefined |
There was a problem hiding this comment.
Suggested change
| * @param deviceFilePath The path to an existing remote file on the device. This variable can be predefined | |
| * @param deviceFilePath The path to an existing remote file on the device. This parameter can be predefined |
| @@ -88,6 +93,37 @@ public void deleteFileFromDevice(String filePath) | |||
| deviceActions.deleteFile(filePath); | |||
| } | |||
|
|
|||
| /** | |||
| * Download a file by <b>filePath</b> from the device and save its content to <b>scopes</b> variables with name | |||
There was a problem hiding this comment.
Suggested change
| * Download a file by <b>filePath</b> from the device and save its content to <b>scopes</b> variables with name | |
| * Downloads a file at <b>filePath</b> from the device and save its content to <b>scopes</b> variables with name |
| * When I download file `$filePath` from device and save its content to $scopes variable `$variableName` | ||
| * </code> | ||
| * | ||
| * @param filePath The path to an existing remote file on the device. This variable can be predefined |
There was a problem hiding this comment.
Suggested change
| * @param filePath The path to an existing remote file on the device. This variable can be predefined | |
| * @param filePath The path to an existing remote file on the device. This parameter can be predefined |
… save its content to variable
IBrun
force-pushed
the
download_file_from_device
branch
from
012018e
to
b5d13a5
Compare
valfirst
approved these changes
Mar 27, 2023
uarlouski
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… save its content to variable