Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vividus] Remove deprecated internal property for all composite files #4239

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

valfirst
Copy link
Collaborator

Previously property bdd.configuration.all-composite-paths was internal (it's not expected to be used by end-users) and it's used to configure composite files paths: both internal and external. But it's turned out users misused the property and overrode default VIVIDUS composite steps, the decision was taken to drop the property and it was implemented in #3436. The property was deprecated in favour of engine.composite-paths to do not break backward compatibility.

@valfirst valfirst requested a review from a team as a code owner August 16, 2023 14:35
@github-actions
Copy link

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #4239 (ba013aa) into master (4f2001c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4239   +/-   ##
=========================================
  Coverage     97.21%   97.21%           
  Complexity     6377     6377           
=========================================
  Files           893      893           
  Lines         18364    18364           
  Branches       1209     1209           
=========================================
  Hits          17852    17852           
  Misses          403      403           
  Partials        109      109           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@valfirst valfirst merged commit fa1823b into master Aug 17, 2023
9 checks passed
@valfirst valfirst deleted the remove-deprecated-internal-property branch August 17, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants