Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vividus] Add Java 21 migration notice #4809

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

valfirst
Copy link
Collaborator

@valfirst valfirst commented Feb 8, 2024

No description provided.

@valfirst valfirst requested a review from a team as a code owner February 8, 2024 14:02
Copy link

github-actions bot commented Feb 8, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (1b0d6cc) 97.42% compared to head (93ccca8) 97.37%.
Report is 1 commits behind head on master.

Files Patch % Lines
...c/main/java/org/vividus/configuration/Vividus.java 25.00% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4809      +/-   ##
============================================
- Coverage     97.42%   97.37%   -0.05%     
  Complexity     6593     6593              
============================================
  Files           918      918              
  Lines         18993    19005      +12     
  Branches       1269     1270       +1     
============================================
+ Hits          18503    18506       +3     
- Misses          384      392       +8     
- Partials        106      107       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
31.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@valfirst valfirst merged commit ffdc4aa into master Feb 9, 2024
6 of 9 checks passed
@valfirst valfirst deleted the add-java-21-migration-notice branch February 9, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants