Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[util] Percent-encode all non-ASCII characters in URL fragment #4917

Merged

Conversation

valfirst
Copy link
Collaborator

No description provided.

@valfirst valfirst requested a review from a team as a code owner March 20, 2024 16:54
Copy link

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.38%. Comparing base (1d48a53) to head (83eb4e7).

Files Patch % Lines
...-util/src/main/java/org/vividus/util/UriUtils.java 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4917   +/-   ##
=========================================
  Coverage     97.38%   97.38%           
  Complexity     6598     6598           
=========================================
  Files           921      921           
  Lines         19071    19072    +1     
  Branches       1269     1269           
=========================================
+ Hits          18573    18574    +1     
  Misses          390      390           
  Partials        108      108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 20, 2024

@valfirst valfirst merged commit f27f6a7 into master Mar 21, 2024
8 of 9 checks passed
@valfirst valfirst deleted the percent-encode-all-non-ascii-characters-in-url-fragment branch March 21, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants