[plugin-web-app-playwright] Add frame switching steps #5141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5141 +/- ##
============================================
+ Coverage 97.40% 97.41% +0.01%
- Complexity 6697 6722 +25
============================================
Files 929 929
Lines 19347 19392 +45
Branches 1286 1288 +2
============================================
+ Hits 18845 18891 +46
Misses 392 392
+ Partials 110 109 -1 ☔ View full report in Codecov by Sentry. |
valfirst
requested changes
Jun 19, 2024
Comment on lines
97
to
102
| FrameLocator currentFrame = uiContext.getCurrentFrame(); | ||
| while (currentFrame != null && !currentFrame.owner().isVisible()) | ||
| { | ||
| uiContext.resetFrame(); | ||
| currentFrame = uiContext.getCurrentFrame(); | ||
| } |
There was a problem hiding this comment.
move this logic to UiContext
...s-plugin-web-app-playwright/src/main/java/org/vividus/ui/web/playwright/steps/PageSteps.java
Show resolved
Hide resolved
avinBar
force-pushed
the
switching_frames_steps
branch
from
823adfb
to
3a67b8f
Compare
valfirst
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.