[plugin-excel] Add ability to preserve cells format #5142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draker94
force-pushed
the
add_ability_to_handle_excel_types
branch
from
551ce12
to
91e30ef
Compare
valfirst
requested changes
Jun 20, 2024
draker94
force-pushed
the
add_ability_to_handle_excel_types
branch
2 times, most recently
from
0d5a7e9
to
76edba4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5142 +/- ##
============================================
- Coverage 97.41% 97.40% -0.01%
- Complexity 6697 6722 +25
============================================
Files 929 930 +1
Lines 19347 19398 +51
Branches 1286 1288 +2
============================================
+ Hits 18847 18895 +48
- Misses 391 393 +2
- Partials 109 110 +1 ☔ View full report in Codecov by Sentry. |
draker94
force-pushed
the
add_ability_to_handle_excel_types
branch
from
76edba4
to
9fd6508
Compare
valfirst
requested changes
Jun 20, 2024
vividus-plugin-excel/src/main/java/org/vividus/excel/transformer/ExcelTableTransformer.java
Outdated
Show resolved
Hide resolved
vividus-plugin-excel/src/main/java/org/vividus/steps/ExcelDocumentValidationSteps.java
Outdated
Show resolved
Hide resolved
vividus-tests/src/main/resources/story/integration/TableTransformers.story
Outdated
Show resolved
Hide resolved
draker94
force-pushed
the
add_ability_to_handle_excel_types
branch
from
9fd6508
to
7b8dd26
Compare
valfirst
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4553
If we want to add cell typing it makes sense add ability to preserve cells format, otherwise, for example, dates, will be displayed as a number, and all numbers themselves will be displayed in fractional format no matter with which style we created the cell