Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin-web-app] Add option to limit screenshots max height #5269

Conversation

draker94
Copy link
Contributor

@draker94 draker94 commented Aug 1, 2024

No description provided.

@draker94 draker94 requested a review from a team as a code owner August 1, 2024 13:51
@draker94 draker94 force-pushed the add_ability_to_limit_screenshot_height branch from fca0337 to e0a42af Compare August 1, 2024 14:00
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.62%. Comparing base (c2c4e36) to head (e0a42af).
Report is 2 commits behind head on master.

Files Patch % Lines
.../ui/web/screenshot/WebScreenshotConfiguration.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5269      +/-   ##
============================================
+ Coverage     97.51%   97.62%   +0.11%     
- Complexity     6931     6941      +10     
============================================
  Files           956      956              
  Lines         20105    20117      +12     
  Branches       1322     1323       +1     
============================================
+ Hits          19605    19639      +34     
+ Misses          392      368      -24     
- Partials        108      110       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@draker94 draker94 closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants