[plugin-web-app-playwright] Add more locator types #5288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5288 +/- ##
=========================================
Coverage 97.62% 97.62%
- Complexity 6945 6947 +2
=========================================
Files 959 959
Lines 20144 20162 +18
Branches 1323 1323
=========================================
+ Hits 19666 19684 +18
Misses 368 368
Partials 110 110 ☔ View full report in Codecov by Sentry. |
valfirst
requested changes
Aug 8, 2024
| |Locate elements that are input with @type="radio" and their label text value matches the specified searh value | ||
| |radioButton(One) | ||
|
|
||
| |`elementName` |
There was a problem hiding this comment.
Suggested change
| |`elementName` | |
| |`name` |
let's use just name
and deprecate elementName locator from Selenium plugin in a separate PR
avinBar
force-pushed
the
playwright_extra_locators
branch
from
f94d4ac
to
94a85df
Compare
valfirst
force-pushed
the
playwright_extra_locators
branch
from
94a85df
to
7ad687a
Compare
valfirst
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.