Add ability to hide Shadow DOM attachments in report #5432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5432 +/- ##
=========================================
Coverage 97.64% 97.64%
- Complexity 7015 7017 +2
=========================================
Files 971 971
Lines 20365 20368 +3
Branches 1331 1332 +1
=========================================
+ Hits 19885 19888 +3
Misses 368 368
Partials 112 112 ☔ View full report in Codecov by Sentry. |
valfirst
approved these changes
Oct 9, 2024
valfirst
requested changes
Oct 9, 2024
| @@ -44,6 +44,12 @@ a|`true` + | |||
| |`true` | |||
| |Whether to publish the application source code on failure or not | |||
|
|
|||
| |`ui.publish-shadow-dom-source-on-failure` | |||
There was a problem hiding this comment.
this will also affect mobile app plugin properties
| @@ -7,6 +7,7 @@ ui.wait.timeout=PT1M | |||
| ui.wait.polling-period=PT2S | |||
|
|
|||
| ui.publish-source-on-failure=true | |||
| ui.publish-shadow-dom-source-on-failure=true | |||
There was a problem hiding this comment.
it's applicable only for web apps
vkepin
force-pushed
the
remove_shadow_dom
branch
from
1077fa3
to
0683f17
Compare
valfirst
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.