feat: Improve font configuration in the docker image #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MurakamiShinyu
commented
Jul 1, 2022
MurakamiShinyu
commented
- remove poor quality fonts (Unifont, IPAGothic, WenQuanYiZenHei)
- install Microsoft TrueType core fonts (Andale Mono, Arial, Arial Black, Comic Sans MS, Courier New, Georgia, Impact, Times New Roman, Trebuchet MS, Verdana, and Webdings)
- install all Noto fonts (including Noto CJK fonts, such as "Noto Serif CJK JP" and "Noto Sans CJK JP")
- font alias Win/Mac mincho and gothic font names to Noto CJK fonts ("Yu Mincho" → "Noto Serif CJK JP", "Hiragino Sans" → "Noto Sans CJK JP", etc)
- resolves Improve font configuration in the docker image #303
- remove poor quality fonts (Unifont, IPAGothic, WenQuanYiZenHei)
- install Microsoft TrueType core fonts (Andale Mono, Arial, Arial Black, Comic Sans MS, Courier New, Georgia, Impact, Times New Roman, Trebuchet MS, Verdana, and Webdings)
- install all Noto fonts (including Noto CJK fonts, such as "Noto Serif CJK JP" and "Noto Sans CJK JP")
- font alias Win/Mac mincho and gothic font names to Noto CJK fonts ("Yu Mincho" → "Noto Serif CJK JP", "Hiragino Sans" → "Noto Sans CJK JP", etc)
---
- resolves #303
|
#309 を先にマージしてください。 |
| # install all Noto fonts | ||
| && apt-get install -y fonts-noto \ | ||
| # font aliases for Noto CJK fonts | ||
| && echo '<?xml version="1.0"?>\ |
There was a problem hiding this comment.
font alias Win/Mac mincho and gothic font names to Noto CJK fonts ("Yu Mincho" → "Noto Serif CJK JP", "Hiragino Sans" → "Noto Sans CJK JP", etc)
@MurakamiShinyu この対応を入れない場合でも問題なく動作すると思うのですが、Aliasを設定するのにはなにか理由はありますか？
There was a problem hiding this comment.
@spring-raining #303 (comment) （font-family: serif を指定しても明朝体にならない問題と対策）で説明しました。ご覧ください。
spring-raining
approved these changes
Jul 2, 2022
This was referenced Jul 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.