Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker.yml, fixing deploying VIVO issue #3688

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

chenejac
Copy link
Contributor

VIVO GitHub issue:
3687

What does this pull request do?

This PR is resolving the issue with packaging VIVO for the needs of making a Docker container. It is resolved in the similar way as 27137bb

Interested parties

Tag (@ mention) interested parties or, if unsure, @VIVO-project/vivo-committers

@chenejac chenejac requested review from roflinn, a user and litvinovg April 15, 2022 09:59
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't say this fixes a deployment issue but rather fixes CI where required dependencies are yet to be published. This is good as it fixes current CI issues but is a bit misleading as if one pulled master branch alone it may not build for them without also cloning the other repositories.

@litvinovg litvinovg merged commit 971e3d9 into vivo-project:main Apr 19, 2022
@chenejac chenejac linked an issue Apr 20, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker GitHub action is not working
2 participants