Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] Query fix to use language filtering for website links in profiles #3795

Merged
merged 1 commit into from
Nov 23, 2022
Merged

[i18n] Query fix to use language filtering for website links in profiles #3795

merged 1 commit into from
Nov 23, 2022

Conversation

litvinovg
Copy link
Collaborator

VIVO GitHub issue

What does this pull request do?

Fixes query to use language filtering for website links in profiles

How should this be tested?

  • Create person profile
  • Add website link, switch language, edit link label
  • Verify that only one label is shown on profile's page.

Interested parties

@tawahle @chenejac @bkampe

chenejac
chenejac approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as it is described. Thanks

bkampe
bkampe reviewed Nov 17, 2022
View reviewed changes
Copy link
Contributor

@bkampe bkampe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with lables like expected.
But if I edit the URL after that it gets a little weird (only edited, did not add another url):

grafik

grafik

grafik

@litvinovg litvinovg mentioned this pull request Nov 22, 2022
Merged
@litvinovg
Copy link
Collaborator Author

Works with lables like expected. But if I edit the URL after that it gets a little weird (only edited, did not add another url):

grafik

grafik

grafik

Please try PR. It should resolve the bug you have found.

@chenejac chenejac changed the base branch from main to i18n-redesign November 22, 2022 10:54
@chenejac chenejac merged commit cf3dde2 into vivo-project:i18n-redesign Nov 23, 2022
@chenejac chenejac mentioned this pull request Dec 20, 2022
Merged
ghost pushed a commit that referenced this pull request Feb 23, 2023
@litvinovg @wwelling
query fix to use language filtering VIVO-3793 (#3795)
bfe4da8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkampe bkampe bkampe approved these changes

@chenejac chenejac chenejac approved these changes

@tawahle tawahle Awaiting requested review from tawahle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@litvinovg @chenejac @bkampe