Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Bootstrap and updated CSS for Wilma theme to make it responsive #3909

Merged
merged 14 commits into from
Dec 7, 2023

Conversation

milospp
Copy link
Contributor

@milospp milospp commented Sep 25, 2023

GitHub issue 3910
GitHub PR Vitro 429

What does this pull request do?

Added bootstrap (only grid style) CSS and modified Wilma theme to leverage its responsive design feature and enhance the overall layout.

What's new?

Mobile optimised desing
Avoided horizontal scroll

How should this be tested?

Open every page and test by resizing up to around 400px in width (Mobile device toolbar can be used in google chrome to simulate phone display)

Additional Notes:

Here is the video example

  • The Left window is VIVO with old Wilma theme
  • The middle window is a new, updated Wilma theme
  • The right window is Tenderfoot theme (just for comparison)

Video Example
https://youtu.be/9B0_cevrEeE

@chenejac chenejac linked an issue Sep 26, 2023 that may be closed by this pull request
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milospp great work, it looks a lot of pages are responsive now in the case of using wilma theme. Can you please also check whether co-author network page (there is a link from a researcher profile page) and temporal graph page (there is a link from an organization profile page) can be also responsive in the case of small devices?

@rasteginas
Copy link

Hi, when loading the main page in the Firefox browser, the search button text is not in it's place.
ScreenshotMain

I also noticed that the list of tabs is not displayed correctly, like in the Tenderfoot theme.
ScreenshotTabs

@milospp
Copy link
Contributor Author

milospp commented Oct 15, 2023

Hi, when loading the main page in the Firefox browser, the search button text is not in it's place. ScreenshotMain

I also noticed that the list of tabs is not displayed correctly, like in the Tenderfoot theme. ScreenshotTabs

I changed the HTML of the search bar on the homepage, can you check again does it works now on Firefox? I wasn't able to reproduce the same bug.
Also, I fixed text wrapping in that menu ("View All" button)
When you build an app, clear the cache and hard reload the page (sometimes the browser caches old CSS files)

chenejac
chenejac previously approved these changes Oct 17, 2023
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milospp Works well for me (Google Chrome). Let's wait @rasteginas to check how it looks like in Firefox.

@rasteginas
Copy link

I tested the template. Looks good.

@chenejac
Copy link
Contributor

@milospp bootstrap.min.js should be included in the code, some bootstrap java script functions are used in the extended search.

Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milospp well done, thanks

@chenejac chenejac merged commit f7eb169 into vivo-project:main Dec 7, 2023
4 checks passed
chenejac added a commit to chenejac/VIVO that referenced this pull request Jan 18, 2024
litvinovg added a commit to litvinovg/VIVO that referenced this pull request Mar 28, 2024
chenejac added a commit that referenced this pull request Mar 28, 2024
Revert "Added Bootstrap and updated CSS for Wilma theme to make it responsive (#3909)"
milospp added a commit to milospp/VIVO that referenced this pull request Apr 9, 2024
Added Bootstrap and updated CSS for Wilma theme to make it responsive (vivo-project#3909)

* Added bootstrap and updated CSS for Wilma theme to make it responsive

* Fixed View All position

* Fixed footer

* Added responsiveness to Page managment table

* Fixed CapabilityMap responsive

* modified Photo Cropping page and minor fixes

* Removed unused libraries

* Fixed horizonal scroll in the site admin pages

* Minor fix in Capability map page

* fix: Fixed serach bar button moving out of place

* fix: Co-author Network graph size on mobile phone

* Fixed tenderfoot bootstrap in search page

* Updated bootstrap location and refactored propert group tabs

* Reimplemented tab state persistence after refresh feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make wilma theme responsive
4 participants