Fixed jquery selector for capability map tabs #3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know it's not the point of this issue and PR and it's a non-trivial task, but would be great if we could upgrade the jQuery version. The version VIVO uses is from 2016 and is flagged as a security risk. #3528 |
Let's resolve this in the separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Fixes the unresponsive behavior of capability map nodes in the Nemo theme when clicked. The issue stemmed from an incorrect jQuery selector used in the theme's jQuery version.
What's new?
Resolved the jQuery selector issue by adding single quotes to the value of the href attribute:
$(".titles li a[href='#" + name + "']")...
How should this be tested?