fix: allow self editors to create individuals in faux property forms #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenejac
previously approved these changes
Jul 11, 2022
...du/cornell/mannlib/vitro/webapp/edit/n3editing/controller/EditRequestDispatchController.java
Outdated
Show resolved
Hide resolved
litvinovg
force-pushed
the
faux_property_create_ind
branch
from
1f84bfd
to
95ce681
Compare
bkampe
approved these changes
Jul 12, 2022
chenejac
approved these changes
Jul 12, 2022
|
I gave this is a spin and it works. I also did a quick check to make sure there wasn't a regression to the issue described by #106. Looks good. Thanks for the quick fix @litvinovg. |
ghost
pushed a commit
that referenced
this pull request
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Allow self editors to create individuals in faux property forms
How should this be tested?
As a self editor add geographic location and create new instance in the form, see error
Verify that admins still able to create individuals
Verify that admins still able to edit pages
Latest release candidate + this fix
Interested parties
@hudajkhan @gneissone @chenejac @wwelling @bkampe