Bug in parsing path with dots

[TroyKomodo]

#[test]
fn test_dots_no_ext() {
    let mut tree = PathTree::new();
    let _ = tree.insert("/:name", 1);

    let result = tree.find("/abc.xyz.123");
    assert!(result.is_some());

    let (value, params) = result.unwrap();
    assert_eq!(value, &1);

    assert_eq!(params.params(), &[("name", "abc.xyz.123")]);
}

#[test]
fn test_dots_ext() {
    let mut tree = PathTree::new();
    let _ = tree.insert("/:name.123", 1);

    let result = tree.find("/abc.xyz.123");
    assert!(result.is_some());

    let (value, params) = result.unwrap();
    assert_eq!(value, &1);

    assert_eq!(params.params(), &[("name", "abc.xyz")]);
}

I would expect both tests to pass, however only the test_dots_no_ext passes.

[fundon]

Hi @TroyKomodo,

I added the test cases, use tree.insert("/:name*.123", 1);.

The :name pattern does not match -, ., ~, /,\\,: with a splitter in a piece.
Both :name+ and :name* match it.

So we can use :name+ or :name* to handle it.

[TroyKomodo]

Oh I see I did not expect that. Is there any reason the : splitter doesn't match .?
Also, what causes the 2nd test to fail if it's not matching the dot. I assume it's using the abc.123 as the name of the parameter.

[fundon]

PR welcome.

Sorry, it's too long, I need to read codes.

[TroyKomodo]

PR welcome.

Sorry, it's too long, I need to read codes.

No it's not a problem, I was just asking if you knew why what the matcher was doing when it matched. I am indifferent on the syntax if you think it's a feature worth adding I would be happy to PR for it.

[fundon]

I think that case should be matched. Your expectation was right.